Cherry-pick #10787 to 7.0: [Heartbeat] Fix missing url.* fields on TCP NXDOMAIN#11202
Merged
andrewvc merged 1 commit intoelastic:7.0from Mar 12, 2019
Merged
Cherry-pick #10787 to 7.0: [Heartbeat] Fix missing url.* fields on TCP NXDOMAIN#11202andrewvc merged 1 commit intoelastic:7.0from
andrewvc merged 1 commit intoelastic:7.0from
Conversation
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per `{hostname,port}` instead of once per `{hostname}`. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.
Related (but different) 6.x issue: elastic#10777
Fix import formatting
(cherry picked from commit 821baec)
ruflin
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10787 to 7.0 branch. Original message:
TCP checks are not adding URL fields on NXDOMAIN endpoints. This fixes that issue.
It does so by ensuring that URL metadata is added before executing the check, and not during, as done previously.
A side effect of this is that we now perform DNS lookups once per
{hostname,port}instead of once per{hostname}. This is worth the increased simplicity however, as the code would be quite convoluted otherwise, which would put us at risk for more bugs.Related (but different) 6.x issue: #10777